Re-Introduce Font Compatibility #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed typeface to Franklin Gothic Medium Condensed - fits the UI better and is somewhat similar to the font used in the video - Added check to allow use of old font if it exists in typical location (also made it work regardless of user!)
|
seems like for usability, custom font should be a getopts / option, and it should default to ./visuals/whatever.ttf; just using a font from the local folder makes it so this runs on macos / linux. |
Author
|
Just trying to keep the default behaviour but add a fallback for those that don't have the font like myself, the intent was to make it non-invasive to the original functionality while improving compatibility. |
Author
|
@carykh a lot of people are opening issues due to this error, would it be ok to merge? |
Contributor
|
Looks good to me |
azealo
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.