Four functionality additions to make roots-contentful more flexible#65
Open
davidgustys wants to merge 6 commits intocarrot:masterfrom
Open
Four functionality additions to make roots-contentful more flexible#65davidgustys wants to merge 6 commits intocarrot:masterfrom
davidgustys wants to merge 6 commits intocarrot:masterfrom
Conversation
…unction, 3. path function now has second parameter passed containing all content types, 4. minor execution flow reordering
Contributor
|
Hi @gdeividas! First off, thank you very much for these wonderful additions to Secondly, I would like to apologize for not responding to this PR sooner. I've been having a few issues with notifications on Github, so it didn't quite catch my eye until now as I have focused my attention entirely on development. However, Is there any chance you could open a separate PR that adds these features to the Be sure to read the updated contributor guidelines for that branch for any information on development processes |
added 5 commits
February 1, 2016 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now you can specify were "content_type's" are attached globally and per content_type, rather than always getting assign to "contentful".
Basically ability to set "content_type" locals manually rather than always automatically
Very useful when you need 'data' form other content_type for curren type's path generation.., i.e having
metacontent_type, on which other content_type may depend..Basically set "urls"/ write files right before compilation, so that
pathfn, has all the data for really custom path generation..