Update countries.yml #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
China area code regx
Contributor
|
I guess this Wikipedia article on the structure of phone numbers used in China says that this regex is alright? |
Contributor
|
@oiahoon Perhaps you can edit the title of this Pull Request to explain what it does? "Update countries.yml" does not explain, but the description does. Perhaps you can use the description to create a title? |
olleolleolle
approved these changes
Nov 3, 2020
Contributor
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
Having read the Wikipedia article, I support this change - it looks correct!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
China area code regex