Phone type mapping and PNG support#36
Open
jensbocklage wants to merge 3 commits intocarlos22:masterfrom
Open
Conversation
vcards my contain phone entries of type main as the standard type. So this type should not be discarded.
Home-fax and work-fax must map to fax
PNGs will be converted to JPGs by using imagejpeg($image_png, $image_jpg, 100);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
234e547: I added "main" as phone type to the mapping. It maps to "work".
84a5e1c: As soon as "fax" is identified, it makes sense to map this number to "fax_work". Even, if it would be "fax_home". But this does not exist in the Fritz!box.
3dc93b3: PNG support (by converting PNGs to JPGs with PHP functions).