Normalize field spec instances in catalog-realm #3880
+146
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request normalizes field spec instances across the catalog-realm by correcting the specType attribute and standardizing field naming conventions.
Changes:
- Changed
specTypefrom "card" to "field" in all field spec instances - Renamed
title/descriptiontocardTitle/cardDescriptionat the root level - Standardized
cardInfonested fields (replacingtitle,description,thumbnailURLwithname,notes,summary,cardThumbnailURL) - Removed outdated
titlefields from nested example objects in AudioFieldSpec
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| YearFieldSpec/28586f71-ae89-4a22-b5e6-eb640271c16e.json | Changed specType to "field", repositioned cardTitle |
| WeekFieldSpec/4b22d528-586f-41ae-89aa-22f5e6eb6402.json | Renamed title/description to cardTitle/cardDescription, updated cardInfo structure |
| TimeRangeFieldSpec/87ec994b-22d5-4858-af71-ae89aa22f5e6.json | Standardized field naming and specType |
| TimePeriodFieldSpec/fd42a287-ec99-4b22-9528-586f71ae89aa.json | Applied field normalization |
| TimeFieldSpec/c2d571fd-42a2-47ec-994b-22d528586f71.json | Updated to standard field structure |
| RelativeTimeFieldSpec/ed74a6c2-d571-4d42-a287-ec994b22d528.json | Normalized field spec format |
| RecurringPatternFieldSpec/b27590ed-74a6-42d5-b1fd-42a287ec994b.json | Applied normalization with truncated cardTitle |
| RatingFieldSpec/8a795bb2-7590-4d74-a6c2-d571fd42a287.json | Fixed incorrect cardTitle and normalized structure |
| QuarterFieldSpec/e8a4788a-795b-4275-90ed-74a6c2d571fd.json | Standardized field naming |
| QuantityFieldSpec/863082e8-a478-4a79-9bb2-7590ed74a6c2.json | Applied field normalization |
| NumberFieldSpec/f8ea8805-8068-481e-953e-2166c21cd1a9.json | Normalized field spec format |
| MultipleImageFieldSpec/ddd219dc-8efa-4586-b082-e8a4788a795b.json | Updated to standard structure |
| MonthYearFieldSpec/c34eb6dd-d219-4c8e-ba25-863082e8a478.json | Applied field normalization |
| MonthFieldSpec/a5b2c1c3-4eb6-4dd2-99dc-8efa25863082.json | Standardized field naming |
| MonthDayFieldSpec/6ce6c8a5-b2c1-434e-b6dd-d219dc8efa25.json | Normalized field spec format |
| ImageFieldSpec/7c9e416c-e6c8-45b2-81c3-4eb6ddd219dc.json | Applied field normalization |
| DurationFieldSpec/a4eb337c-9e41-4ce6-88a5-b2c1c34eb6dd.json | Updated to standard structure |
| DayFieldSpec/ed6780a4-eb33-4c9e-816c-e6c8a5b2c1c3.json | Repositioned cardTitle and changed specType |
| DatetimeStampFieldSpec/98da21ed-6780-44eb-b37c-9e416ce6c8a5.json | Standardized field naming |
| DatetimeFieldSpec/1bee4e98-da21-4d67-80a4-eb337c9e416c.json | Normalized structure but removed example values |
| DateRangeFieldSpec/5339d01b-ee4e-48da-a1ed-6780a4eb337c.json | Applied field normalization |
| DateFieldSpec/b9c37d53-39d0-4bee-8e98-da21ed6780a4.json | Updated to standard structure |
| ColorFieldSpec/f1b66e4b-b9c3-4d53-b9d0-1bee4e98da21.json | Normalized field spec format |
| AudioFieldSpec/aad14b4f-2b08-468f-ab34-18d9890c39c3.json | Removed per-example title fields and normalized structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "occurrences": 2 | ||
| }, | ||
| "description": null, | ||
| "cardTitle": "Recurring Pattern Field Spe", |
There was a problem hiding this comment.
The cardTitle value appears to be truncated. It reads "Recurring Pattern Field Spe" but should be "Recurring Pattern Field Spec" (missing the final 'c'). This inconsistency with other field specs in this PR should be corrected.
Suggested change
| "cardTitle": "Recurring Pattern Field Spe", | |
| "cardTitle": "Recurring Pattern Field Spec", |
Comment on lines
15
to
26
| "short": null, | ||
| "readMe": null, | ||
| "cardInfo": { | ||
| "name": null, | ||
| "notes": null, | ||
| "title": null, | ||
| "description": null, | ||
| "thumbnailURL": null | ||
| "summary": null, | ||
| "cardThumbnailURL": null | ||
| }, | ||
| "specType": "card", | ||
| "standard": "2026-01-08T16:03:00", | ||
| "description": null, | ||
| "customFormat": "2026-01-08T16:04:00", | ||
| "specType": "field", | ||
| "standard": null, | ||
| "cardTitle": "Datetime Field Spec", | ||
| "customFormat": null, |
There was a problem hiding this comment.
The example values for the "short", "standard", and "customFormat" fields are being changed from valid datetime strings to null. This removes the example data that demonstrates how these field variants should be used. Verify that this data removal is intentional, as it may reduce the usefulness of this field spec as a reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linear: https://linear.app/cardstack/issue/CS-10082/fix-incorrect-fieldname-and-spectype-in-field-spec-instance
Changes