Draft
Conversation
rdlrt
reviewed
Apr 6, 2022
Contributor
rdlrt
left a comment
rdlrt
left a comment
There was a problem hiding this comment.
Added few comments for discussion
Member
Author
|
One thing I am considering is to save the responses from |
Member
Author
|
TO-DO: Make sure tests check offline data (asset registry cache / pool_offline_data). |
rdlrt
force-pushed
the
main
branch
6 times, most recently
from
990d7ee to
3b76dc8
Compare
rdlrt
force-pushed
the
main
branch
2 times, most recently
from
ee63dfd to
f1e2d9e
Compare
rdlrt
force-pushed
the
main
branch
7 times, most recently
from
51340db to
ea67f5e
Compare
rdlrt
force-pushed
the
main
branch
3 times, most recently
from
3acb686 to
8529bd3
Compare
rdlrt
force-pushed
the
main
branch
3 times, most recently
from
2df340b to
538d94d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds data-tests integration for HAproxy to run advanced test for servers in topology of monitoring nodes. First determines a healthy node to use for comparison from a list of trusted nodes, then tests each server in the topology against it.
If the tested node does not pass tests it is marked for maintenance (
MAINT) until next run when it could pass. If aMAINTnode passes the data tests, it is brought back toREADYstate.To-do:
Where should the reviewer start?
Motivation and context
Which issue it fixes?
How has this been tested?