Swap out Rc for Arc to make stories thread-safe.#1
Open
ndarilek wants to merge 1 commit intocaranatar:masterfrom
Open
Swap out Rc for Arc to make stories thread-safe.#1ndarilek wants to merge 1 commit intocaranatar:masterfrom
Rc for Arc to make stories thread-safe.#1ndarilek wants to merge 1 commit intocaranatar:masterfrom
Conversation
Author
|
Hey, wanted to ping this PR. I'd rather stick with your upstream for now since this is the only change I need, but I'd like to use this parser in my engine and will be forking it next week so I can go ahead with that. I'd rather not maintain a fork just for this change if it can be avoided. :) Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this! I was looking for ways to use Twee files in Bevy. After using it in my build process to generate dialog clips from story files, I needed to load those stories as assets into the engine. Unfortunately, your use of
RcmakesStorynon-threadsafe, so I couldn't add it as a Bevy asset.This PR swaps out your use of
RcwithArc. Haven't tested it yet, but it compiles, and I'm now able to work with stories as assets in Bevy.