feat: 동적으로 테이블이 변경되는 기능을 구현한다 by drunkenhw · Pull Request #25 · car-ffeine/admin

drunkenhw · 2023-08-14T10:04:47Z

📄 Summary

먼저 일단 리뷰를 받고 싶어서 제출합니다. 아직 다른 api는 안만들어져있는 것 같아서 간단히 야미가 만들어놓은 기능과 합쳤습니다

🕰️ Actual Time of Completion

30시간

🙋🏻 More

close #14

[#14] [#14-temp]

[#14]

[#14-temp]

feb-dain

타입 오류 개선해주세요~

뭔가 복잡하게 돌아간 느낌이네요🤔
단순한 로직으로 개선할 수 있을 것 같아 보여요

feb-dain · 2023-08-14T12:48:47Z

src/components/Navigation/NavigationMenu.tsx

+      ))}
+      <Button sx={{ color: '#fff', wordBreak: 'keep-all' }} onClick={() => handleClickMenu()}>
+        {isLoggedIn ? '로그아웃' : '간편로그인'}
+      </Button>{' '}


{' '} 지워주세요

feb-dain · 2023-08-14T12:50:12Z

src/components/Table/AdminTableBody.tsx

+const AdminTableBody = <T, K extends keyof T>({ data, columns }: TableRowsProps<T, K>) => {
  const { openModal } = modalActions;

-  const handleOpenModal = () => {
+  function handleOpenModal() {


컴포넌트는 function, 이벤트 핸들러 등의 함수는 화살표 함수 써주세요

feb-dain · 2023-08-14T13:24:46Z

src/App.tsx

+  const [tableData, setTableData] = useState(stationMockData);
+  const token = memberTokenStore.getState();
+  const { lastPage, stationSummaryList } = useFetchStations(token, 1);
+  if (token === '') return <LoginModalContent />;


개행 주세여

feb-dain · 2023-08-14T13:26:12Z

src/App.tsx

 function App() {
+  const [tableTitle, setTableTitle] = useState('충전소 관리');
+  const [tableColumn, setTableColumn] = useState(stationColumns);
+  const [tableData, setTableData] = useState(stationMockData);


여기 밑에도 개행 줘도 될 것 같아여

feb-dain · 2023-08-14T13:37:29Z

src/types/index.ts

+const memberColumns: ColumnType<MemberDetails, keyof MemberDetails>[] = [
+  {
+    key: 'id',
+    header: 'ID',
+  },
+  {
+    key: 'email',
+    header: 'E-MAIL',
+  },
+  {
+    key: 'role',
+    header: '회원 권한',
+  },
+];
+const faultReportColumns: ColumnType<FaultReportDetails, keyof FaultReportDetails>[] = [
+  {
+    key: 'id',
+    header: 'ID',
+  },
+  {
+    key: 'stationId',
+    header: '충전소 ID',
+  },
+  {
+    key: 'memberId',
+    header: '회원 ID',
+  },
+];


이렇게 만든 이유가 있을까요??

Suggested change

const memberColumns: ColumnType<MemberDetails, keyof MemberDetails>[] = [

{

key: 'id',

header: 'ID',

},

{

key: 'email',

header: 'E-MAIL',

},

{

key: 'role',

header: '회원 권한',

},

];

const faultReportColumns: ColumnType<FaultReportDetails, keyof FaultReportDetails>[] = [

{

key: 'id',

header: 'ID',

},

{

key: 'stationId',

header: '충전소 ID',

},

{

key: 'memberId',

header: '회원 ID',

},

];

const faultReportColumns = {

id: 'ID',

stationId: '충전소 ID'

....

}

const faultRepoutColumnList = getTypedObjectEntries(faultReportColumns)

이렇게 만들어서 쓰면 안되나요??

저는 혹시 key, header 외의 다른 속성들을 넣을 수 있지 않을까라는 생각에 했습니다. 하지만 굳이 지금 단계에선 과하고 코드의 복잡도만 높아지겠네요 수정하겠습니다

feb-dain · 2023-08-14T13:47:29Z

src/constants/index.ts

  '충전기 신고 관리',
-  '간편 로그인',
 ] as const;


간편 로그인 왜 사라졌죠? 🤔 처음에 로그인 해야만 보이는 걸로 바꿔서 없앴나요?

아니요 간편 로그인은 클릭했을 때 간편로그인 창이 떠야하지만, 나머지 메뉴 버튼들은 table이 나와야해서 성격이 달라 map으로 적용하기가 어려운 부분이 있어서 성격이 비슷한 친구들만 묶었습니다..

feb-dain · 2023-08-14T13:47:59Z

src/hooks/stations/useFetchStations.ts

 export const useFetchStations = (token: string, page: number) => {
  const [lastPage, setLastPage] = useState(1);
-  const [stationSummaryList, setStationSummaryList] = useState<StationProps[]>([]);
+  const [stationSummaryList, setStationSummaryList] = useState<StationDetails[]>([]);


타입 이름 stationSummary가 아닐까요?

feb-dain · 2023-08-14T13:48:22Z

src/mocks/index.ts

+export const misinformnationMockData = Array.from(
+  { length: ROWS_PER_PAGE },
+  () => misinformationMock
+);
+
+export function getMockData<T>(title: string): Array<T> {
+  switch (title) {
+    case '충전소 관리':
+      return stationMockData as Array<T>;
+    case '충전소 제보 관리':
+      return misinformnationMockData as Array<T>;


misinformation으로 바꿔주세요~ 오타났습니다

feb-dain · 2023-08-14T13:49:47Z

src/types/index.ts

+  role: string;
+}
+
+const memberColumns: ColumnType<MemberDetails, keyof MemberDetails>[] = [


이게 왜 type에 있죠...? constant 아닌가요? 이하 동문입니다~

feb-dain · 2023-08-14T13:49:59Z

src/types/index.ts

+    key: 'role',
+    header: '회원 권한',
+  },
+];


개행주세여

drunkenhw and others added 4 commits August 14, 2023 18:53

feat: 유동적으로 테이블이 변경되는 기능 추가

ae7ce5e

[#14] [#14-temp]

feat: 다른 기능이 있는 버튼 분리

f3a088d

[#14] [#14-temp]

fix: 스토리북 타입 오류 개선

360549f

[#14]

feat: 요청 기능과 병합

d30dcd1

[#14-temp]

drunkenhw added the feat 기능 추가 label Aug 14, 2023

drunkenhw requested a review from feb-dain August 14, 2023 10:04

drunkenhw self-assigned this Aug 14, 2023

drunkenhw had a problem deploying to github-pages August 14, 2023 10:04 — with GitHub Actions Failure

feb-dain reviewed Aug 14, 2023

View reviewed changes

Conversation

drunkenhw commented Aug 14, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📄 Summary

🕰️ Actual Time of Completion

🙋🏻 More

Uh oh!

feb-dain left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

feb-dain Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

feb-dain Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

drunkenhw commented Aug 14, 2023 •

edited by github-actions bot

Loading

feb-dain left a comment •

edited

Loading

feb-dain Aug 14, 2023 •

edited

Loading

feb-dain Aug 14, 2023 •

edited

Loading