Upgrade project to Rust 2024 edition #36
Conversation
Upgraded the Rust edition from 2021 to 2024 in all `Cargo.toml` files. Ran `cargo fix --edition` and performed necessary manual code changes to address new lifetime capture rules in `impl Trait` that were introduced in the 2024 edition. This involved refactoring the `comfyui-api` crate to manage the `WebSocketApi` client within the main `Comfy` struct to resolve lifetime errors. Additionally, addressed several `clippy` warnings that arose after the edition upgrade, including: - Correcting over-indented documentation comments. - Boxing large error variants to reduce their size on the stack. - Collapsing nested `if` statements for better readability. Validated the changes by running `cargo build`, `cargo test`, and `cargo clippy`. All checks passed successfully. A `database.sqlite` file, which was generated during testing, has been removed from version control. Note: Nix-related CI checks (`verify-nix` job) could not be run locally due to sandbox environment limitations preventing Nix installation.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
This commit upgrades the project to the Rust 2024 edition.
PR created automatically by Jules for task 4662141466396937184