Skip to content

fix: rename TestColumn classes to MockColumn to fix pytest collection warnings #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hashwnath wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

fix: rename TestColumn classes to MockColumn to fix pytest collection warnings #1200

hashwnath wants to merge 14 commits into from

Conversation

@hashwnath
Copy link

@hashwnath hashwnath commented Jan 20, 2026

Summary

Fixes #1147

Problem

Pytest was generating collection warnings because helper classes named TestColumn and TestColumnWProps were being detected as test classes due to their 'Test' prefix, but failed collection because they have __init__ constructors.

PytestCollectionWarning: cannot collect test class 'TestColumn' 
because it has a __init__ constructor

Solution

Renamed the helper/mock classes:

  • TestColumn → MockColumn
  • TestColumnWProps → MockColumnWProps

This makes it clear these are mock/helper classes, not test classes, and eliminates the pytest collection warnings.

Files Changed

  • dataprofiler/tests/profilers/test_histogram_utils.py
  • dataprofiler/tests/profilers/test_numeric_stats_mixin_profile.py

Testing

This is a straightforward refactoring with no logic changes. All existing tests should pass.

taylorfturner and others added 13 commits June 14, 2024 13:11
@taylorfturner @JGSweets
@gliptak @SchadtJ
staging/main/0.12.0 (capitalone#1145)
4545841 
* refactor: Upgrade the models to use keras 3.0 (capitalone#1138)

* Replace snappy with cramjam (capitalone#1091)

* add downloads tile (capitalone#1085)

* Replace snappy with cramjam

* Delete test_no_snappy

---------

Co-authored-by: Taylor Turner <taylorfturner@gmail.com>

* pre-commit fix (capitalone#1122)

* Bug fix for float precision calculation using categorical data with trailing zeros. (capitalone#1125)

* Revert "Bug fix for float precision calculation using categorical data with t…" (capitalone#1133)

This reverts commit d3159bd.

* refactor: move layers outside of class

* refactor: update model to keras 3.0

* fix: manifest

* fix: bugs in compile and train

* fix: bug in load_from_library

* fix: bugs in CharCNN

* refactor: loading tf model labeler

* fix: bug in data_labeler identification

* fix: update model to use proper softmax layer names

* fix: formatting

* fix: remove unused line

* refactor: drop support for 3.8

* fix: comments

* fix: comment

---------

Co-authored-by: Gábor Lipták <gliptak@gmail.com>
Co-authored-by: Taylor Turner <taylorfturner@gmail.com>
Co-authored-by: James Schadt <jamesrschadt@gmail.com>

* Fix Tox (capitalone#1143)

* tox new

* update

* update

* update

* update

* update

* update

* update

* update tox.ini

* update

* update

* remove docs

* empty retrigger

* update (capitalone#1146)

* bump version

* update 3.11

* remove dist/

---------

Co-authored-by: JGSweets <JGSweets@users.noreply.github.com>
Co-authored-by: Gábor Lipták <gliptak@gmail.com>
Co-authored-by: James Schadt <jamesrschadt@gmail.com>
@armaan-dhillon @JGSweets
@gliptak @taylorfturner @SchadtJ @micdavis
Staging release 0.13.0 (capitalone#1165) (capitalone#1166)
50da93f 
* refactor: Upgrade the models to use keras 3.0 (capitalone#1138)

* Replace snappy with cramjam (capitalone#1091)

* add downloads tile (capitalone#1085)

* Replace snappy with cramjam

* Delete test_no_snappy

---------



* pre-commit fix (capitalone#1122)

* Bug fix for float precision calculation using categorical data with trailing zeros. (capitalone#1125)

* Revert "Bug fix for float precision calculation using categorical data with t…" (capitalone#1133)

This reverts commit d3159bd.

* refactor: move layers outside of class

* refactor: update model to keras 3.0

* fix: manifest

* fix: bugs in compile and train

* fix: bug in load_from_library

* fix: bugs in CharCNN

* refactor: loading tf model labeler

* fix: bug in data_labeler identification

* fix: update model to use proper softmax layer names

* fix: formatting

* fix: remove unused line

* refactor: drop support for 3.8

* fix: comments

* fix: comment

---------





* Fix Tox (capitalone#1143)

* tox new

* update

* update

* update

* update

* update

* update

* update

* update tox.ini

* update

* update

* remove docs

* empty retrigger

* update (capitalone#1146)

* Add Python 3.11 to GHA (capitalone#1090)

* add downloads tile (capitalone#1085)

* Add Python 3.11 to GHA

* Replace snappy with cramjam (capitalone#1091)

* add downloads tile (capitalone#1085)

* Replace snappy with cramjam

* Delete test_no_snappy

---------



* Update dask modules

* Install dask dataframe

* Update dask modules in precommit

* Correct copy/paste error

* Try again to clear Unicode

* Rolled back pre-commit dask version

* Add py311 to tox

* Bump dask to 2024.4.1

* Bump python-snappy 0.7.1

* Rewrite labeler test

* Correct isort

* Satisfy black

* And flake8

* Synced with requirements

---------



* [Vuln Fix]: Resolve mend vulnerabilities related to requests. (capitalone#1162)

* resolved check-manifest issue

* updating keras version pin to <=3.4.0

* adding comment in requirements.txt to trigger mend check

---------



---------

Co-authored-by: JGSweets <JGSweets@users.noreply.github.com>
Co-authored-by: Gábor Lipták <gliptak@gmail.com>
Co-authored-by: Taylor Turner <taylorfturner@gmail.com>
Co-authored-by: James Schadt <jamesrschadt@gmail.com>
Co-authored-by: Michael Davis <36012613+micdavis@users.noreply.github.com>
@shania-m
chore: update mypy dependencies (capitalone#1171)
c0f86fb
@shania-m
chore: refactor release process (capitalone#1170)
48d0fd5
@shania-m
chore: Update publish-package.yml (capitalone#1172)
aafeef6
@shania-m
gh pages update (capitalone#1173)
ed8188a 
* chore: create publish-docs.yml

* brought in docs directory
@shania-m
Update gh-pages workflows (capitalone#1174)
09c2062 
* chore: update workflow to properly install pandoc
* chore: update build to build to a LATEST directory
@shania-m
Remove Versions from Intro page (capitalone#1175)
9919af4
@shania-m
chore: Workflow permissions (capitalone#1182)
5a1ee0a 
* chore: permissions for publish-docs
@mhmotamedi
docs: add architecture.rst for algorithm rationale, testing, versioni…
1a84430 
…ng (capitalone#1181)

* docs: add architecture.rst for algorithm rationale, testing, and versioning details

* docs: remove manual table of contents from architecture.rst for Furo compatibility and edit  content
@ryanSoley
ops: drop python 3.9 & resolve vulns (capitalone#1192)
c035a05 
* ops: drop python 3.9 (EOL)
* ops: add whitesource config
* fix: don't add python 3.12 yet
* ops: add whitesource config to MANIFEST
* fix: remove `--forked` to fix coverage
* fix: remove tests that depend on `--forked`
* ops: update vulnerable libraries
@ryanSoley
ops: properly configure whitesource (capitalone#1195)
ebb7ee1 
* ops: properly configure whitesource
* ops: add whitesource config to MANIFEST
@ryanSoley
fix: use core config (capitalone#1198)
5a381d5
@hashwnath hashwnath requested a review from a team as a code owner January 20, 2026 02:10
@hashwnath
fix: rename TestColumn classes to MockColumn to fix pytest warnings
60256a3 
Fixes capitalone#1147

Pytest was generating collection warnings because helper classes
named TestColumn and TestColumnWProps were being detected as test
classes due to their 'Test' prefix, but failed collection because
they have __init__ constructors.

This commit renames:
- TestColumn -> MockColumn
- TestColumnWProps -> MockColumnWProps

This makes it clear these are mock/helper classes, not test classes,
and eliminates the pytest collection warnings.
@hashwnath hashwnath force-pushed the fix/pytest-collection-warnings branch from 9df498f to 60256a3 Compare January 20, 2026 02:30
@CLAassistant
Copy link

CLAassistant commented Jan 20, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hashwnath @CLAassistant @taylorfturner @armaan-dhillon @shania-m @mhmotamedi @ryanSoley