[DON'T MERGE] ops: update vulnerable libraries #1191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
stephenpardy
previously approved these changes
Sep 16, 2025
ryanSoley
commented
Sep 16, 2025
Comment on lines
+49
to
+52
| [coverage:run] | ||
| omit = | ||
| dataprofiler/tests/* | ||
| relative_files = true |
Member
Author
There was a problem hiding this comment.
this has somehow fixed the coverage, but caused tests to start failing. specifically those that check the default seed and default log level
Member
Author
There was a problem hiding this comment.
going to revert all changes but this and the original version changes to try to isolate the issue
Member
Author
There was a problem hiding this comment.
and now we're back to the tests passing but the coverage being too low 🙃
stephenpardy
previously approved these changes
Sep 16, 2025
ryanSoley
changed the title
Member
Author
|
closing for #1192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
relative_filesto fix coverage for forks