Skip to content

chore: update mypy dependencies #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shania-m merged 4 commits into from
Mar 12, 2025
Merged

chore: update mypy dependencies #1171

shania-m merged 4 commits into from
Mar 12, 2025

Conversation

@shania-m
Copy link
Contributor

@shania-m shania-m commented Mar 11, 2025 •
edited
Loading

unblocks the pre-commit check, currently mypy is checking dask source files:

/home/runner/.cache/pre-commit/repo6yii67ru/py_env-python3/lib/python3.10/site-packages/dask/array/_array_expr/_backends.py:72: error: Condition can't be inferred, unable to merge overloads
59
/home/runner/.cache/pre-commit/repo6yii67ru/py_env-python3/lib/python3.10/site-packages/dask/array/_array_expr/_backends.py:79: error: Condition can't be inferred, unable to merge overloads
60
Found 2 errors in 1 file (checked 59 source files)

61

@shania-m shania-m requested a review from a team as a code owner March 11, 2025 19:31
thebrianbn
thebrianbn approved these changes Mar 12, 2025
View reviewed changes
Copy link

@thebrianbn thebrianbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shania-m shania-m changed the title chore: Update README.md chore: update mypy dependencies Mar 12, 2025
@shania-m shania-m merged commit c0f86fb into main Mar 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@armaan-dhillon armaan-dhillon armaan-dhillon approved these changes

+2 more reviewers

@thebrianbn thebrianbn thebrianbn approved these changes

@cliuc1 cliuc1 cliuc1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shania-m @thebrianbn @armaan-dhillon @cliuc1