test refactor for floating point failures + mypy fix #1169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
test_categorical_diffandtest_diff_categorical_chi2_testwhich were failing locally due to some floating point errors but not failing when run on a different machine -- this refactors them so the floating point comparisons will be machine/platform agnosticflake8revin.pre-commit-config.yaml(was running into a local error with older version)dataprofiler/data_readers/parquet_data.py# type: ignore[override]comments for 4 lines causing mypyoverrideerrors withTODOstatements for contextdisable_error_code = overridefromsetup.cfgThe 4 mypy override errors that this PR was supposed to address require adding a
@propertytag to theprofile()method ofNumericStatsMixinand this is a breaking change as it led to many tests failing.TODOcomments highlight this.