Skip to content

fix: sync with capiscio-core v1.0.2#2

Merged
beonde merged 2 commits intomainfrom
fix/core-version-sync
Nov 21, 2025
Merged

fix: sync with capiscio-core v1.0.2#2
beonde merged 2 commits intomainfrom
fix/core-version-sync

Conversation

@beonde
Copy link
Member

@beonde beonde commented Nov 21, 2025

This PR updates the wrapper to use capiscio-core v1.0.2, which is the correct latest version.

It also updates the package version to 1.0.2 to match the core binary version.

Note: capiscio-core v1.0.2 introduces breaking changes (timeout units required), which this wrapper exposes directly to the user. Users must now provide units for the --timeout flag (e.g. 10s instead of 10).

Copilot AI review requested due to automatic review settings November 21, 2025 15:43
@github-actions
Copy link

✅ All checks passed! Ready for review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR downgrades the capiscio wrapper from v2.1.2 to v1.0.2 to sync with capiscio-core v1.0.2, which is described as the correct latest version. The change exposes breaking changes from the core binary requiring timeout flag units (e.g., 10s instead of 10).

Key changes:

  • Downgrade package version from 2.1.2 to 1.0.2 in pyproject.toml
  • Update CORE_VERSION constant from "2.1.2" to "1.0.2" in manager.py

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/capiscio/manager.py Updates CORE_VERSION constant to match new core binary version 1.0.2
pyproject.toml Downgrades package version from 2.1.2 to 1.0.2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"

[project]
name = "capiscio"
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions that capiscio-core v1.0.2 introduces breaking changes requiring timeout units. However, there's no documentation update (e.g., CHANGELOG.md, migration guide, or README update) warning users about these breaking changes. Consider adding documentation about the breaking change to help users migrate, especially since this affects the --timeout flag usage.

Suggested change
name = "capiscio"
name = "capiscio"
# v1.0.2 introduces a breaking change: the --timeout flag now requires explicit units (e.g., 10s, 1m).
# Please see the updated README.md and CHANGELOG.md for migration instructions.

Copilot uses AI. Check for mistakes.
@beonde
Copy link
Member Author

beonde commented Nov 21, 2025

I've updated the PR to bump the package version to 2.1.3 instead of rolling back to 1.0.2.

This ensures:

  1. We don't conflict with existing published versions on PyPI.
  2. The wrapper still downloads the correct capiscio-core binary (v1.0.2).
  3. Users get the fix via a standard patch update.

@github-actions
Copy link

✅ All checks passed! Ready for review.

@beonde beonde merged commit 80028af into main Nov 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant