Conversation
|
✅ All checks passed! Ready for review. |
There was a problem hiding this comment.
Pull request overview
This PR downgrades the capiscio wrapper from v2.1.2 to v1.0.2 to sync with capiscio-core v1.0.2, which is described as the correct latest version. The change exposes breaking changes from the core binary requiring timeout flag units (e.g., 10s instead of 10).
Key changes:
- Downgrade package version from 2.1.2 to 1.0.2 in pyproject.toml
- Update CORE_VERSION constant from "2.1.2" to "1.0.2" in manager.py
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/capiscio/manager.py | Updates CORE_VERSION constant to match new core binary version 1.0.2 |
| pyproject.toml | Downgrades package version from 2.1.2 to 1.0.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -4,7 +4,7 @@ build-backend = "hatchling.build" | |||
|
|
|||
| [project] | |||
| name = "capiscio" | |||
There was a problem hiding this comment.
The PR description mentions that capiscio-core v1.0.2 introduces breaking changes requiring timeout units. However, there's no documentation update (e.g., CHANGELOG.md, migration guide, or README update) warning users about these breaking changes. Consider adding documentation about the breaking change to help users migrate, especially since this affects the --timeout flag usage.
| name = "capiscio" | |
| name = "capiscio" | |
| # v1.0.2 introduces a breaking change: the --timeout flag now requires explicit units (e.g., 10s, 1m). | |
| # Please see the updated README.md and CHANGELOG.md for migration instructions. |
|
I've updated the PR to bump the package version to This ensures:
|
|
✅ All checks passed! Ready for review. |
This PR updates the wrapper to use
capiscio-corev1.0.2, which is the correct latest version.It also updates the package version to 1.0.2 to match the core binary version.
Note:
capiscio-corev1.0.2 introduces breaking changes (timeout units required), which this wrapper exposes directly to the user. Users must now provide units for the--timeoutflag (e.g.10sinstead of10).