Skip to content

Conversation

@daogrady
Copy link
Contributor

@daogrady daogrady commented Nov 25, 2025

Stacked on #110
Fixes #103

  • introduce a second event that gives users the chance to modify the source CSN before the OpenAPI compilation takes place
  • Exposes events as top level API, containing the two event names for easier and more consistent access to these names

@daogrady daogrady marked this pull request as ready for review November 25, 2025 16:05
@daogrady daogrady requested a review from tim-sh November 25, 2025 16:05
Base automatically changed from feat/emit-event to main November 25, 2025 16:10
@daogrady
Copy link
Contributor Author

@chgeo
We'd like to provide two hooks for users: before the compilation to OpenAPI takes place, so users can modify the input CSN, as well as one after, so users can modify the result before it is written to file.
Do we have naming conventions for this two-phase hook approach?
This PR introduces these events as before:compile.to.openapi and after:compile.to.openapi, but we can still change the nomenclature here.

@daogrady daogrady mentioned this pull request Nov 27, 2025
Copy link
Member

@tim-sh tim-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the 'after' event name, as discussed elsewhere

@tim-sh
Copy link
Member

tim-sh commented Dec 1, 2025

⏰ Afterwards, redo #111

@daogrady daogrady requested a review from tim-sh December 2, 2025 08:18
@daogrady daogrady merged commit 1293dbc into main Dec 2, 2025
8 checks passed
@daogrady daogrady deleted the feat/before-after-events branch December 2, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question] How to hide a service or a property in OpenAPI?

3 participants