-
Notifications
You must be signed in to change notification settings - Fork 187
WD-32254-Updated equal heights row and pattern to use 4 4 8 grid #5729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WD-32254-Updated equal heights row and pattern to use 4 4 8 grid #5729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request migrates the equal heights row pattern and component from the legacy 12-column grid system (4/6/12) to the new 8-column grid system (4/4/8). The changes update grid class names, SCSS grid variables, and refactor the template logic to use a new shared macro for better code reusability.
- Migrated from legacy grid classes (
.row,.col) to new grid classes (.grid-row,.grid-col) - Updated SCSS to use 8-column grid variables (
$grid-8-columns) instead of legacy 12-column variables - Extracted equal heights block rendering into a reusable shared macro
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
templates/_macros/vf_equal-heights.jinja |
Updated grid class names from legacy to 8-column grid, changed quote styles, and refactored to use new shared macro |
templates/_macros/shared/vf_equal-heights-block.jinja |
New shared macro containing extracted equal heights block rendering logic for reusability |
scss/_patterns_equal-height-row.scss |
Migrated grid variables from 12-column to 8-column system, updated calculations, added support for both new and legacy grid class selectors |
releases.yml |
Added release notes for version 4.40.0 documenting the grid migration |
package.json |
Bumped version from 4.39.0 to 4.40.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
petesfrench
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA'd on some different pages and looks good. Just left some minor comments in the code.
| & .p-equal-height-row--wrap { | ||
| @media screen and (width >= $breakpoint-large) { | ||
| grid-template-columns: repeat(9, minmax(0, 1fr)); | ||
| grid-template-columns: repeat(#{(math.div($grid-8-columns, 4) * 3)}, minmax(0, 1fr)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we gain anything from abstracting these values into a calculation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was made by Julie but I suppose it is to eliminate hard coded values and replace it with consistent grid-8-column variable
|
Thanks for adding linked title @immortalcodes , I'm adding +1! |
Done
Fixes [list issues/bugs if needed]
#5587
https://warthogs.atlassian.net/browse/WD-32254
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots
[if relevant, include a screenshot or screen capture]