-
Notifications
You must be signed in to change notification settings - Fork 37
feat: implement legacy endpoints for non breaking logging #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
==========================================
+ Coverage 70.82% 70.88% +0.06%
==========================================
Files 108 108
Lines 9443 9549 +106
Branches 841 850 +9
==========================================
+ Hits 6688 6769 +81
- Misses 2585 2609 +24
- Partials 170 171 +1
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
4c1a423 to
83a9a59
Compare
…ed with current code
83a9a59 to
7b6e6cf
Compare
pedro-avalos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work; this will definitely make the transition much smoother. I have left some suggestions and questions regarding some of the changes.
pedro-avalos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Great work!
Description
This PR is meant to make the migration from the old logging mechanism to the new logging introduced by #666 more smoother.
Note: This branch is waiting for #666 to be merged on Monday Dec1, after merging, will rebase to display only relevant additions
Server Changes:
/outputand/serial_outputendpoints in server. This is required so both CLI and agents can write/read temporarily to/from this endpoints.Agent Changes
CLI
During transition, this would be the upgrade flow
Resolved issues
CERTTF-757
Documentation
Web service API changes
Tests
Tested in Staging
The following scenarios were validated successfully in staging:
mainand CLI usingstablechannelLive Polling was available through
/outputendpointAgents were able to send results back to server
Results retrievable by CLI through the
/resultendpointNew endpoint is available but does not hold any data as agent still is not aware of it
stablechannelLive Polling was available through
/outputendpointAgents were able to send results back to server
Results retrievable by CLI through the
/resultendpointAdditionally, agent now writes to both legacy and new endpoints so output data is also available from new endpoint (not retrievable by CLI):
Live Polling was available through
/log/outputendpointCLI can now poll to specific phases