Remove digest validation #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the validation requiring an event to contain digests for all hashes as provided by the TCG_EfiSpecIDEvent.
The only thing I can find in the TPM specification is this:
> The TCG_EfiSpecIDEvent{} structure contains one or more
> TCG_Efi_SpecIdEventAlgorithmSize structures. These contain the algorithmID and3060
> digestSize for the measurement algorithms used by firmware. As consumers of the event
> log may not recognize the algorithmID, the digestSize field allows a parser to consume
> the events in the log without knowing the implicit size of the algorithm defined by the
> algorithmID.
This leads me to believe that this validation is not required by the spec, and it causes otherwise
valid TCG logs (such as those produced by Windows) to not be parsed correctly.
There is already code to abort in case an unknown algorithm is encountered, which to me seems like the
important part to guard against.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the validation requiring an event to contain digests for all algorithms as provided by the TCG_EfiSpecIDEvent.
The only thing I can find in the TPM specification is this:
This leads me to believe that this validation is not required by the spec, and it causes otherwise valid TCG logs (such as those produced by Windows) to not be parsed correctly.
There is already code to abort in case an unknown algorithm is encountered, which to me seems like the important part to guard against.