Skip to content

Conversation

@holmanb
Copy link
Member

@holmanb holmanb commented Jan 5, 2026

No description provided.

@holmanb holmanb changed the title confdb: test what gofumpt looks like on confdb confdb: run gofumpt looks like on confdb Jan 5, 2026
@holmanb
Copy link
Member Author

holmanb commented Jan 5, 2026

Context: This change demonstrates at a small scale some of the kinds of changes that gofumpt produces. Non-functional changes are obviously a burden on any codebase, but the goal is that there would be a future ongoing benefit due to a more strictly standardized format. If gofumpt is incorporated into CI, this would result in less format-related review comments and less drift between projects that share code.

This change was created by running gofumpt -l -w confdb/.

related PR

fyi @miguelpires

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.49%. Comparing base (d95f2b9) to head (65556ae).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16392   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files        1342     1341    -1     
  Lines      183262   183255    -7     
  Branches     2438     2438           
=======================================
- Hits       142013   142008    -5     
- Misses      32646    32649    +3     
+ Partials     8603     8598    -5     
Flag Coverage Δ
unittests 77.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Mon Jan 5 18:02:19 UTC 2026
The following results are from: https://github.com/canonical/snapd/actions/runs/20719050821

Failures:

Executing:

  • openstack:ubuntu-core-24-64:tests/core/services
  • openstack:ubuntu-20.04-64:tests/main/snapshot-users

Restoring:

  • openstack:ubuntu-20.04-64:tests/main/interfaces-cups-control
  • openstack:ubuntu-20.04-64:tests/main/snapshot-users
  • openstack:ubuntu-20.04-64:tests/main/
  • openstack:ubuntu-20.04-64:
  • openstack:ubuntu-20.04-64:tests/main/
  • openstack:ubuntu-20.04-64:
  • openstack:ubuntu-24.04-64:tests/main/nss-modules:winbind

@miguelpires miguelpires requested review from alfonsosanchezbeato and removed request for miguelpires January 6, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant