Address feedback on SBOM endpoint in security tab implementation #5510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Copilot is not a collaborator of the repo |
Copilot
AI
changed the title
[WIP] Update SBOM endpoint implementation based on feedback
Address feedback on SBOM endpoint in security tab implementation
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
No changes needed. After review, the feedback from @steverydz regarding the
snap_has_sbomsfunction was already addressed in the parent PR. The SBOM endpoint returning 404 for non-existent SBOMs is the expected behavior - thesnap_has_sbomspre-check is used to determine UI visibility in the security tab, not to prevent 404 errors.How to QA
dotrun/firefox)/sbom/<snap_id>/<revision>endpointTesting
Issue / Card
Stacked PR addressing feedback on #5508
Screenshots
N/A - no visual changes
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.