fix: check stderr output deactivating luks volume#500
Open
gabelluardo wants to merge 1 commit intocanonical:masterfrom
Open
fix: check stderr output deactivating luks volume#500gabelluardo wants to merge 1 commit intocanonical:masterfrom
gabelluardo wants to merge 1 commit intocanonical:masterfrom
Conversation
8bfd7b6 to
e40f5c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
systemd-cryptsetupbehaves unexpectedly when trying to unmount a volume that doesn't exist or is already inactive. Even though it fails and printsDevice is not activeto stderr, it still returns an exit code0, consequentially theDeactivatefunction doesn't return an error and the operation is reported as successful bytpmctl.I’ve updated the check to ensure that if there is any output in stderr, it's treated as an error even if the exit code is
0.