Skip to content

Conversation

@valentindavid
Copy link
Collaborator

No description provided.

@valentindavid valentindavid marked this pull request as ready for review January 29, 2026 09:27
@valentindavid
Copy link
Collaborator Author

We had confirmation from a customer that it fixes the issue.

Copy link
Collaborator

@chrisccoulson chrisccoulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I do have another idea for this, but this change is ok as a temporary fix for the immediate customer issue. I'm going to add the ability to proceed during install if the system is in user mode rather than deployed mode, and that will involve an additional option to enable support for user mode here (WithSecureBootUserMode or something). With that option, we'll generate 2 branches (one for deployed mode without the additional measurements and one for user mode with the additional measurements) which will enable a user who proceeded with user mode to enable deployed mode without needing a recovery key. Without the option, only deployed mode would be supported as we don't want to automatically create profiles for user mode if the user didn't previously choose this.

That would indirectly solve the issue here because you could just use WithSecureBootUserMode outside of the options created by CheckResult and you would get a profile with both branches.

@chrisccoulson chrisccoulson merged commit e638825 into canonical:master Jan 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants