Make AuthRequestor indicate the returned credential type #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends AuthRequestor.RequestUserCredential to indicate the type of the returned credential. Whilst the existing systemd and plymouth implementations of AuthRequestor will always return the requested credential types (as we don't know what the user intended to enter), a future boot UI may provide a way for the user to decide whether to enter a passphrase, PIN or recovery key and for this to be communicated back to us. Whilst this isn't particularly useful right now, I wanted to add the logic to ActivateContext because it will affects the logic of a follow-up PR for sending error messages to Plymouth. Fixes: FR-12439
chrisccoulson
force-pushed
the
auth-requestor-return-credential-type
branch
from
f2de5c4 to
fc52b90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends
AuthRequestor.RequestUserCredentialto indicate the type ofthe returned credential. Whilst the existing systemd and plymouth
implementations of
AuthRequestorwill always return the requestedcredential types (as we don't know what the user intended to enter), a
future boot UI may provide a way for the user to decide whether to enter
a passphrase, PIN or recovery key and for this to be communicated back
to us.
Whilst this isn't particularly useful right now, I wanted to add the
logic to
ActivateContextbecause it will affects the logic of a follow-upPR for sending error messages to Plymouth.
Fixes: FR-12439