Skip to content

preinstall: Return warnings as errors if RunChecks is already going to return an error #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisccoulson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

preinstall: Return warnings as errors if RunChecks is already going to return an error #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions efi/preinstall/checks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,9 @@ func RunChecks(ctx context.Context, flags CheckFlags, loadedImages []secboot_efi
}

if len(deferredErrs) > 0 {
// If we are returning one or more error, then append any warnings
// to the returned errors as well.
deferredErrs = append(deferredErrs, warnings...)
return nil, joinErrors(deferredErrs...)
}

Expand Down
Loading
Loading