Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 27, 2025

  • Understand the issue: release.py doesn't handle pre-release versions like "3.4.0b2"
  • Identify affected functions:
    • bump_minor_version - fails on pre-release versions
    • bump_patch_version - fails on pre-release versions
    • get_new_tag_for_release - regex rejects pre-release versions
    • parse_version - doesn't return pre-release suffix
    • get_new_scenario_version - needs to preserve pre-release suffix
    • get_new_version_post_release - regex rejects pre-release versions
  • Update parse_version to return pre-release suffix
  • Update bump_minor_version to handle pre-release versions
  • Update bump_patch_version to handle pre-release versions
  • Update get_new_tag_for_release to accept pre-release versions
  • Update get_new_scenario_version to preserve pre-release suffix
  • Update get_new_version_post_release to accept pre-release versions
  • Test the changes
  • Run code review
  • Run CodeQL security check
Original prompt

This section details on the original issue you should resolve

<issue_title>[chore] scenario: cleanup the per-file-ignores introduced when including testing in ops linting</issue_title>
<issue_description>In #1694, we removed the ruff config from testing/pyproject.toml, allowing the ruff settings in the pyproject.toml in the project directory to apply to testing/ (note: the actual formatting changes were made separately from the config changes in #1691, which has been added to the git blame ignore list).

The purpose of this PR was to unify on single-quotes as the quoting style, however it also revealed that many other ruff linting rules were not being checked for testing/. These rules have been added to the per-file-ignores in the project level pyproject.toml for testing/* and testing/tests/*.

We should clean up these ignores as much as possible.</issue_description>

<agent_instructions>The only file that should be changed is release.py. The only other relevant file in the repo is HACKING.md where the instructions for using release.py are found.

The script works when the version is something like "3.4.0" or "3.4.1". It does not work correctly if the new or old version is something like "3.4.0b2", but it should. Note that ops and ops-tracing have the same version, and ops-scenario always has a version that has a major 5 higher than the others (3.4 is 8.4). Note also that the user can override the version suggested.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI self-assigned this Nov 27, 2025
@tonyandrewmeyer
Copy link
Collaborator

I linked the wrong instructions to the ticket 😞

@tonyandrewmeyer tonyandrewmeyer deleted the copilot/cleanup-per-file-ignores branch November 27, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[chore] scenario: cleanup the per-file-ignores introduced when including testing in ops linting

2 participants