Partial implementation of ext_image_copy_capture_v1 cursor sessions #4632
+384
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The session uses the CursorObserverMultiplexer to track the cursor position, and a source-dependent backend class to transform the output space coordinates to match those of the captured image. Currently it sends a white triangle as the cursor image rather than the actual cursor image.
TICS Quality Gate❌ Failedmir
❌ Condition “No new Coding Standard Violations for level 1, 2, 3 with respect to Previous analysis” failed 1 time.
|
||||||||
| File | Issues | |
|---|---|---|
| 🪲 Total | ❌ Blocking | |
| 2 | +2 | |
See the results in the TICS Viewer
The following files have been checked for this project
- src/server/frontend_wayland/ext_image_capture_v1.cpp
- src/server/frontend_wayland/ext_image_capture_v1.h
- src/server/frontend_wayland/wayland_connector.cpp
- src/server/frontend_wayland/wayland_connector.h
- src/server/frontend_wayland/wayland_default_configuration.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
This implements cursor the cursor session parts of the ext_image_copy_capture_v1 protocol. At present, it sends a dummy cursor image, which will be replaced with the real cursor in a follow-up PR.
Cursor position tracking is done via the CursorObserverMultiplexer, with a source-dependent backend class responsible for transforming the output space cursor coordinates to those of the corresponding image capture, and indicating whether the cursor is within bounds.
This can be tested like so:
WAYLAND_DISPLAY=wayland-1 wayvncChecklist