Skip to content

Conversation

@alesstimec
Copy link
Collaborator

This PR contains a generated documentation reference
for the jaas CLI tool for release refs/tags/v3.3.11.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the JAAS CLI plugin reference documentation to reflect changes in release v3.3.11. The documentation is auto-generated and includes new features, permission types, and command additions.

  • Adds support for role and cloud resource types with corresponding permissions
  • Updates permission relation types for controllers (replacing "loginer" with "audit_log_viewer" and "can_addmodel")
  • Introduces new "jaas upgrade-to" command for controller version upgrades

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1596 to +1597
Certain reserved tags exist to denote specific resource types: - The user-everyone@external tag represents all users. - The controller-jimm tag represents the JIMM controller itself.

Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reserved tags description appears to be on a single line without proper formatting. The list items should be separated (either by line breaks or proper bullet formatting) to improve readability. Currently, the dashes are used as separators in running text rather than as list markers.

Suggested change
Certain reserved tags exist to denote specific resource types: - The user-everyone@external tag represents all users. - The controller-jimm tag represents the JIMM controller itself.
Certain reserved tags exist to denote specific resource types:
- The ``user-everyone@external`` tag represents all users.
- The ``controller-jimm`` tag represents the JIMM controller itself.

Copilot uses AI. Check for mistakes.
::

loginer
audit_log_viewer (only relevent for the JIMM controller)
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "relevent" is misspelled. It should be "relevant".

Suggested change
audit_log_viewer (only relevent for the JIMM controller)
audit_log_viewer (only relevant for the JIMM controller)

Copilot uses AI. Check for mistakes.

user tag = "user-<name>"
group tag = "group-<name>"
role tag = "role-&lt;name&gt;"
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML entity encoding issue: "<" and ">" are being used instead of angle brackets. This should be "role-<name>" which will render as "role-" in the final output, but the inconsistency with other tags on lines 163, 166, and 167 which use actual angle brackets suggests this might be unintended encoding.

Copilot uses AI. Check for mistakes.
controller tag = "controller-<name>"
model tag = "model-<name>"
application offer tag = "offer-<name>"
cloud tag = "cloud-&lt;name&gt;"
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML entity encoding issue: "<" and ">" are being used instead of angle brackets. This should be "cloud-<name>" which will render as "cloud-" in the final output, but the inconsistency with other tags on lines 163, 166, and 167 which use actual angle brackets suggests this might be unintended encoding.

Copilot uses AI. Check for mistakes.
::

loginer
audit_log_viewer (only relevent for the JIMM controller)
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "relevent" is misspelled. It should be "relevant".

Suggested change
audit_log_viewer (only relevent for the JIMM controller)
audit_log_viewer (only relevant for the JIMM controller)

Copilot uses AI. Check for mistakes.

user tag = "user-<name>"
group tag = "group-<name>"
role tag = "role-&lt;name&gt;"
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML entity encoding issue: "<" and ">" are being used instead of angle brackets. This should be "role-<name>" which will render as "role-" in the final output, but the inconsistency with other tags on lines 1604, 1607, and 1608 which use actual angle brackets suggests this might be unintended encoding.

Copilot uses AI. Check for mistakes.
controller tag = "controller-<name>"
model tag = "model-<name>"
application offer tag = "offer-<name>"
cloud tag = "cloud-&lt;name&gt;"
Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML entity encoding issue: "<" and ">" are being used instead of angle brackets. This should be "cloud-<name>" which will render as "cloud-" in the final output, but the inconsistency with other tags on lines 1604, 1607, and 1608 which use actual angle brackets suggests this might be unintended encoding.

Copilot uses AI. Check for mistakes.
Comment on lines +155 to +156
Certain reserved tags exist to denote specific resource types: - The user-everyone@external tag represents all users. - The controller-jimm tag represents the JIMM controller itself.

Copy link

Copilot AI Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reserved tags description appears to be on a single line without proper formatting. The list items should be separated (either by line breaks or proper bullet formatting) to improve readability. Currently, the dashes are used as separators in running text rather than as list markers.

Suggested change
Certain reserved tags exist to denote specific resource types: - The user-everyone@external tag represents all users. - The controller-jimm tag represents the JIMM controller itself.
Certain reserved tags exist to denote specific resource types:
- The user-everyone@external tag represents all users.
- The controller-jimm tag represents the JIMM controller itself.

Copilot uses AI. Check for mistakes.
@tmihoc
Copy link
Member

tmihoc commented Dec 17, 2025

Copilot has revealed some issues. We'll fix them when we've moved the docs into the jimm repo.

@tmihoc tmihoc self-requested a review December 17, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants