feat: add bootstrapping through JIMM #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
reviewed
Oct 10, 2025
Contributor
kian99
left a comment
kian99
left a comment
There was a problem hiding this comment.
Just some comments to think about when this is discussed with Teodora.
ale8k
reviewed
Oct 10, 2025
tmihoc
requested changes
Oct 14, 2025
Member
tmihoc
left a comment
tmihoc
left a comment
There was a problem hiding this comment.
Nice addition! Left some suggestions. Let me know if you'd like to discuss further!
luci1900
changed the title
kian99
reviewed
Oct 14, 2025
Contributor
kian99
left a comment
kian99
left a comment
There was a problem hiding this comment.
I like the brevity of the changes. But I think there are some missing details around the cloud-credentials required on the client
tmihoc
reviewed
Oct 14, 2025
kian99
approved these changes
Oct 15, 2025
Contributor
kian99
left a comment
kian99
left a comment
There was a problem hiding this comment.
Lgtm, few minor things,
- We should tag a new release of JIMM and merge the new jaas cli docs.
- After that we should reference the relevant commands from this doc.
- In that same update, we should also include a note that all config options supported by
juju bootstrapcan be provided tojuju jaas bootstrapwith again a nod to the cli reference doc.
tmihoc
approved these changes
Oct 16, 2025
Member
tmihoc
left a comment
tmihoc
left a comment
There was a problem hiding this comment.
LGTM.
We can do the refactoring we were discussing later.
Thanks!
To the "Manage controllers" how-to add documentation for: - bootstrapping through JIMM - destroying controllers directly and through JIMM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To the "Manage controllers" how-to add documentation for:
Fixes JUJU-8301