Skip to content

Conversation

@alvaromateo
Copy link
Contributor

Done

Add support for exposing multiple ports on the same container.

QA

  • Run poetry install --no-interaction
  • Run DOTRUN_PATH="$(pwd)/.venv/bin/dotrun"
  • Go to any web project
  • Run: $DOTRUN_PATH -p 9008:9008 -p 10008:10008

Check in the docker container that all specified ports are exposed. To do this you can run:

docker container ls
CONTAINER ID   IMAGE                                  COMMAND    CREATED              STATUS              PORTS                                                                      NAMES
8b91dd4a6b61   canonicalwebteam/dotrun-image:latest   "dotrun"   About a minute ago   Up About a minute   0.0.0.0:8004->8004/tcp, 0.0.0.0:9008->9008/tcp, 0.0.0.0:10008->10008/tcp   dotrun-snapcraft-io-1748349434

And in the output of the command, under the PORTS column you should see all the specified ports.

I tested it on a MacOS. It would be nice to have someone test it on a Linux machine before merging.

Issues

Fixes ISSUES-97

Copy link
Contributor

@goulinkh goulinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, asked for some minor changes.
Thanks for filing this PR :)

@alvaromateo
Copy link
Contributor Author

Thanks for the review @goulinkh !
I did the changes you suggested. Could you review again please?

alvaromateo and others added 2 commits June 4, 2025 11:24
Co-authored-by: Goulin Khoge <36013798+goulinkh@users.noreply.github.com>
Copy link
Contributor

@goulinkh goulinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution and applying the changes @alvaromateo :)

@alvaromateo alvaromateo merged commit 0c11c91 into main Jun 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose all the container ports

3 participants