-
Notifications
You must be signed in to change notification settings - Fork 19
feat: add option for exposing multiple ports #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5d13b7f to
6d9ecd9
Compare
goulinkh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, asked for some minor changes.
Thanks for filing this PR :)
5a93df8 to
46ae2ee
Compare
|
Thanks for the review @goulinkh ! |
Co-authored-by: Goulin Khoge <36013798+goulinkh@users.noreply.github.com>
goulinkh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution and applying the changes @alvaromateo :)
Done
Add support for exposing multiple ports on the same container.
QA
poetry install --no-interactionDOTRUN_PATH="$(pwd)/.venv/bin/dotrun"$DOTRUN_PATH -p 9008:9008 -p 10008:10008Check in the docker container that all specified ports are exposed. To do this you can run:
And in the output of the command, under the PORTS column you should see all the specified ports.
I tested it on a MacOS. It would be nice to have someone test it on a Linux machine before merging.
Issues
Fixes ISSUES-97