fix(build-debian): Sanitize dependabot for DEBFULLNAME and DEBEMAIL#117
Closed
fix(build-debian): Sanitize dependabot for DEBFULLNAME and DEBEMAIL#117
Conversation
hk21702
force-pushed
the
build-deb-dependabot
branch
from
fed9d8e to
a6aa461
Compare
Commits made by Dependabot use the name `dependabot[bot]` and email `49699333+dependabot[bot]@users.noreply.github.com`. However, directly using this for DEBFULLNAME and DEBEMAIL causes issues with lintian, where lintian will error with `malformed-contact` against the changes file. Specifically, lintian dislikes the square brackets. For an example of failures caused by this, see the following runs: https://github.com/canonical/authd/actions/runs/23261849890?pr=1275 https://github.com/ubuntu/ubuntu-insights/actions/runs/23259662695/job/67624442465?pr=330 Just suppressing the `malformed-contact` tag isn't a great option in case there is a legitimate issue unrelated to Dependabot. Having CI skip builds when triggered by Dependabot also isn't an option, as we want to see if a dependency change will cause issues. Since the email and name that Dependabot uses appear to be consistent and static, it should be fine to just hardcode the matching logic to prevent any false positives. We use `support@github.com` as the replacement email since Dependabot typically appends the following line at the end of its commit messages: ``` Signed-off-by: dependabot[bot] <support@github.com> ```
hk21702
force-pushed
the
build-deb-dependabot
branch
from
a6aa461 to
0ad7dca
Compare
Contributor
|
I already opened #116 to fix that issue |
Member
Author
Woops, I didn't notice. I'll go ahead and close this one then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits made by Dependabot use the name
dependabot[bot]and email49699333+dependabot[bot]@users.noreply.github.com. However, directly using this for DEBFULLNAME and DEBEMAIL causes issues with lintian, where lintian will error withmalformed-contactagainst the changes file. Specifically, lintian dislikes the square brackets.For an example of failures caused by this, see the following runs:
https://github.com/canonical/authd/actions/runs/23261849890?pr=1275
https://github.com/ubuntu/ubuntu-insights/actions/runs/23259662695/job/67624442465?pr=330
Just suppressing the
malformed-contacttag isn't a great option in case there is a legitimate issue unrelated to Dependabot. Having CI skip builds when triggered by Dependabot also isn't an option, as we want to see if a dependency change will cause issues.Since the email and name that Dependabot uses appear to be consistent and static, it should be fine to just hardcode the matching logic to prevent any false positives. We use
support@github.comas the replacement email since Dependabot typically appends the following line at the end of its commit messages: