Change: simpler command for 'wait service' busy loop#87
Draft
Change: simpler command for 'wait service' busy loop#87
Conversation
Contributor
Author
|
There are pending changes on the service side that would impact this function yet again, let's keep it draft for the time being. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This scriplet is currently abusing a
_run_retryto make sure the service is up and running and being restarted. While the end result is fine, there's no real need to retry that command in particular, and the errors printed while the service is starting are misleading and creates confusion to the user.This PR makes use of a simpler command (a getter) as busy loop, redirecting both stdout and stderr to /dev/null.