Refactor manager.go for improved safety and maintainability #1081
Closed
Muaz-Ibn-Kamal wants to merge 1 commit intocanonical:mainfrom
Closed
Refactor manager.go for improved safety and maintainability #1081Muaz-Ibn-Kamal wants to merge 1 commit intocanonical:mainfrom
Muaz-Ibn-Kamal wants to merge 1 commit intocanonical:mainfrom
Conversation
…ontext parameter to NewSession and EndSession instead of using context.Background - Improved session cleanup by deleting session mapping before calling endSession - Preallocated slice in AvailableBrokers for efficiency - Standardized and clarified error messages - Normalized username handling in BrokerForUser manager.go
Contributor
|
These are the same changes as #1082, which I already reviewed, so I'm closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors manager.go to improve safety, efficiency, and maintainability.
Changes made:
These changes make session handling safer, error messages clearer, and overall code more robust.