fix/#68-incorrect-authorization-action-of-create-comunity-action #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@manh-vv take a look if you have time! |
manh-vv
requested changes
Jun 25, 2020
| { | ||
| account: 'eosio.token', | ||
| authorization: [{ actor: input.creator, permission: 'active' }], | ||
| authorization: [{ actor: payer ? payer : input.creator, permission: 'active' }], |
Member
There was a problem hiding this comment.
We have a discussion in which you told me we need at least two signature.
- from creator
- from payer
Is the statement still valid? If so, is this change still valid?
Contributor
Author
There was a problem hiding this comment.
Let me represent the follow that payer want to create community for other one, that include two actions:
- payer authorize to transfer CAT token to governance contract account to create community account, so
actorhere should be payer not creator, that's why I fix this. - creator authorize to update community information with action
createin governance contract
Contributor
There was a problem hiding this comment.
@danielalvess @manh-vv please help me resolve this MR. Looks like it has been here for a long time !?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge did: