Closed
Conversation
Co-Authored-By: Marcel Garus <hello@marcelgarus.dev>
jwbot
added
P: Compiler v4
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| listener: (line: string, lineCount: number, byteCount: number) => void, | ||
| ): EventEmitter; | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| on(event: "error", listener: (error: any) => void): EventEmitter; |
Check failure
Code scanning / ESLint
Disallow the `any` type
Comment on lines
+31
to
+34
| currentRun = new Promise(async (resolve) => { | ||
| await callback(); | ||
| resolve(null); | ||
| }); |
Check failure
Code scanning / ESLint
Disallow Promises in places not designed to handle them
| await currentRun; | ||
| if (generation != myGeneration) return; // a newer update exists and will run | ||
| // eslint-disable-next-line @typescript-eslint/no-misused-promises, no-async-promise-executor | ||
| currentRun = new Promise(async (resolve) => { |
Check failure
Code scanning / ESLint
Disallow using an async function as a Promise executor
Comment on lines
+123
to
+134
| linebyline(candy.stdout).on("line", async function (line: string) { | ||
| console.info("Line: " + line); | ||
| const message = JSON.parse(line) as AnalyzeMessage; | ||
| switch (message.type) { | ||
| case "read_file": | ||
| candy.stdin.write(await handleReadFileMessage(message)); | ||
| break; | ||
| case "diagnostics": | ||
| diagnostics = message.diagnostics; | ||
| break; | ||
| } | ||
| }); |
Check failure
Code scanning / ESLint
Disallow Promises in places not designed to handle them
jwbot
added
P: Compiler: Language Server
Member
Author
|
Merged as part of #1117 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1091!Based on Martinaise's implementation, but doesn't read updated files from the editor yet (instead loading the file from disk)
Checklist