Open
Conversation
Member
Author
|
@tkurki this change is causing a test to fail in n2k-signalk I am inclined to fix the n2k-signalk since canboatjs and canboat output "000000000" in case. Agreed? |
Collaborator
|
Sure! |
Member
Author
|
After looking at n2k-signalk, I am now thinking of having the User ID be undefined in this case. That way we won't have backwards compatibility issues. |
Collaborator
|
Or null? Either may break code that expects a string. |
Collaborator
|
I mean number. |
Member
Author
|
Yeah, looks like I would have to return 0 in this case to make the existing n2k-signalk code work. Looks like everything else is ok because n2k-signalk currently calls .toString(). |
Removed the reference to 'typescript' branch for checkout.
Removed the build step for signalk-to-nmea2000 in the CI workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #391