fix: use server-side timestamp for instance-started log entry#88
Merged
jarekdanielak merged 1 commit intomainfrom Mar 12, 2026
Merged
fix: use server-side timestamp for instance-started log entry#88jarekdanielak merged 1 commit intomainfrom
jarekdanielak merged 1 commit intomainfrom
Conversation
3c5a65c to
57b7003
Compare
nikku
reviewed
Mar 11, 2026
lib/ExecutionLog.js
Outdated
| }; | ||
| } | ||
|
|
||
| const processInstanceResponse = this._polledResult?.result?.processInstanceResponse; |
Member
There was a problem hiding this comment.
Let's move this to the place where we set the polled result (ExecutionLog#setPolledResult).
57b7003 to
9815425
Compare
jarekdanielak
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #86
Proposed Changes
The instance-started log entry used a client-side
Date.now()timestamp captured when the HTTP response arrived, which could be later than the server-side element instance timestamps for fast tasks (e.g. script tasks), causing wrong entry ordering. Fixed by preferring the server-side process instancestartDatefrom the polled result when available, falling back to the client timestamp before the first poll.Before:

After:

Checklist
Ensure you provide everything we need to review your contribution:
Closes {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}@bpmn-io/srtool