fix: parse WMS bounding boxes as numbers instead of strings #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WMS bounding boxes are defined as [number, number, number, number] but were being parsed as strings from XML attributes. Updated parsing functions to convert values to numbers using parseFloat(). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
jahow
approved these changes
Dec 17, 2025
Member
jahow
left a comment
jahow
left a comment
There was a problem hiding this comment.
Long overdue, thank you for fixing this!
Member
|
Note that this should appear in the release notes, it's not a breaking change per se but it could still have impacts on downstream code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a type inconsistency in WMS bounding box parsing where values were being stored as strings instead of numbers.
BoundingBoxtype is defined as[number, number, number, number], but the parsing functions were returning string values from XML attributescapabilities.tsto convert attribute/text values to numbers usingparseFloat():parseBBox()- for standard BoundingBox elementsparseExGeographicBoundingBox()- for EX_GeographicBoundingBox elements (WMS 1.3.0)parseLatLonBoundingBox()- for LatLonBoundingBox elements (WMS 1.1.x)capabilities.spec.tsandendpoint.spec.tsto expect numbers instead of stringsTest plan
🤖 Generated with Claude Code