Open
Conversation
zhibek
requested changes
Dec 3, 2018
| <body> | ||
| <h1>Cities Information</h1> | ||
| <dl> | ||
| {% for city in cities %} |
Member
There was a problem hiding this comment.
Please add a condition to be displayed if we don't have data on any cities.
app/modules/cityinfo/city_extras.py
Outdated
|
|
||
| def StoreCitiesInto(cities): | ||
| for city in cities: | ||
| entity_key = ndb.Key('CityInfo', city['Location']) |
app/modules/common/city_info.py
Outdated
| logging.info("CityInfoRootPipeline") | ||
|
|
||
| # Read cityinfo.yaml file | ||
| yaml_path = os.path.join(os.path.dirname(__file__), '../cityinfo/cityinfo.yaml') |
Member
There was a problem hiding this comment.
Please abstract this implemenation into a separate function.
app/modules/cityinfo/city_extras.py
Outdated
|
|
||
| return None | ||
|
|
||
| def StoreCitiesInto(cities): |
Member
There was a problem hiding this comment.
Spelling mistake - StoreCitiesInfo
deploy-cron.sh
Outdated
| @@ -0,0 +1,20 @@ | |||
| #!/bin/bash | |||
Member
There was a problem hiding this comment.
This is good. But to keep things simple, let's remove this deploy-cron.sh file and include the logic in deploy.sh instead (in deploy.sh, we don't need to copy all of this file in, we just need to change the gcloud app deploy app-deploy.yaml line to include cron.yaml after app-deploy.yaml (space separated list).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.