Open
Conversation
zhibek
requested changes
Nov 22, 2018
app/modules/common/kinds.py
Outdated
| @@ -0,0 +1,6 @@ | |||
| import webapp2 | |||
Member
There was a problem hiding this comment.
Remove imports that aren't required/used in this file.
| import webapp2 | ||
| import logging | ||
| import os | ||
| from google.appengine.ext import ndb |
Member
There was a problem hiding this comment.
Remove imports that aren't used in this file
app/modules/home.html
Outdated
| <li><a href="/examples/yaml">Yaml example</a></li> | ||
| <li><a href="/training/pipeline/5">Pipeline training</a></li> | ||
| <li><a href="/training/http/30.05/31.25">Http training </a></li> | ||
| <li><a href="/training/http/{{lat}}/{{lng}}">Http training </a></li> |
Member
There was a problem hiding this comment.
Avoid trailing whitespace in links.
| logging.info("DatastoreTrainingHandler") | ||
|
|
||
| # get entities | ||
| entities_for_example_kind = Example.query().fetch(20) |
Member
There was a problem hiding this comment.
Rather than having 20 as a "magic number" lets make a constant LIST_DEFAULT_LIMIT = 20 in this file and use that instead.
| <body> | ||
| <h1>Datastore Training</h1> | ||
| <dl> | ||
| {% for entity in entities %} |
Member
There was a problem hiding this comment.
Let's add a conditional so No entities found is displayed if no entities exist.
zhibek
requested changes
Dec 3, 2018
app/modules/common/kinds.py
Outdated
| @@ -1,4 +1,3 @@ | |||
| import webapp2 | |||
| import logging | |||
| <dt><p>{{ entity.key }}</p></dt> | ||
| <dd><p>{{ entity.value }}</p></dd> | ||
| {% endfor %} | ||
|
|
Member
There was a problem hiding this comment.
Please check redundant newlines and incorrect indentation.
| import logging | ||
| import os | ||
| from google.appengine.ext import ndb | ||
|
|
Member
There was a problem hiding this comment.
Why has an empty newline been left?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.