Adding UML diagrams in API provider perspective Part2#139
Adding UML diagrams in API provider perspective Part2#139stroncoso merged 17 commits intocamaraproject:mainfrom
Conversation
Updated the README to include additional call flow examples and corrected links.
adding registration and call origination_and_disconnection flow
|
Hi @teikuran Thanks very much for the documentation work, it really shapes the API and it brings our eyes over the real implementations problems. I noticed that you include several "ISSUE (NotAddressed)" comments on the doc, do not hesitate to create them on the repo, in order to properly address them one-by-one. Some initial comments:
We can comment it and agreed on results to merge and next steps at today's meeting. Thanks for your contribution. |
...mentation/SupportingDocuments/uml-diagrams-APIprovider/call_origination_and_disconnection.md
Outdated
Show resolved
Hide resolved
...on/SupportingDocuments/uml-diagrams-APIprovider/call_origination_and_disconnection_fig-1.wsd
Outdated
Show resolved
Hide resolved
...on/SupportingDocuments/uml-diagrams-APIprovider/call_origination_and_disconnection_fig-1.wsd
Outdated
Show resolved
Hide resolved
...on/SupportingDocuments/uml-diagrams-APIprovider/call_origination_and_disconnection_fig-1.wsd
Outdated
Show resolved
Hide resolved
...on/SupportingDocuments/uml-diagrams-APIprovider/call_origination_and_disconnection_fig-2.wsd
Outdated
Show resolved
Hide resolved
...on/SupportingDocuments/uml-diagrams-APIprovider/call_origination_and_disconnection_fig-3.wsd
Outdated
Show resolved
Hide resolved
|
Added some suggestions to improve readability of the UML diagrams regarding the webhook events. Apart from that and the issue at Thanks! |
added related issue index number
added related issue index number
update issue description
updated issue description
adding status label to webhook action
adding status label to webhook action
adding status label to webhook action
stroncoso
left a comment
There was a problem hiding this comment.
Hi @teikuran
Amazing documentation. It looks good to me, also I resolved the outdated conversations as they are already covered.
I'm going to approve the PR, we can merge now or wait for the complete content and the resolved fixed documented. It's up to you.
Thanks a lot for your contribution!
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Following Adding UML diagrams in API provider perspective #122, new flow examples are proposed to be added.
Changelog input