Skip to content

Adding UML diagrams in API provider perspective Part2#139

Merged
stroncoso merged 17 commits intocamaraproject:mainfrom
teikuran:some-updates-on-flow-part2
Mar 24, 2026
Merged

Adding UML diagrams in API provider perspective Part2#139
stroncoso merged 17 commits intocamaraproject:mainfrom
teikuran:some-updates-on-flow-part2

Conversation

@teikuran
Copy link
Copy Markdown
Contributor

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

Following Adding UML diagrams in API provider perspective #122, new flow examples are proposed to be added.

Changelog input

 release-note
- UML (for registration and call handling) uploaded to discuss and identify any future issue with baisc call flow understanding

@stroncoso
Copy link
Copy Markdown
Contributor

Hi @teikuran

Thanks very much for the documentation work, it really shapes the API and it brings our eyes over the real implementations problems. I noticed that you include several "ISSUE (NotAddressed)" comments on the doc, do not hesitate to create them on the repo, in order to properly address them one-by-one.

Some initial comments:

  • WebRTC registration lacks of the subscriber number in the body of the request. Currently is only covered on the 200OK reponse from the netowrk. Maybe it will be easier to implement on the application layer, if we include it on the request, but not really sure of the security implications... maybe none.
  • POST SINK_URL looks a little confusing on the diagram, suggested the following formula: POST SINK_URL (session-event) to identify the type of event, or event more, include the content: `POST SINK_URL (session-event: 180 ringing)

We can comment it and agreed on results to merge and next steps at today's meeting.

Thanks for your contribution.
Regards,

@stroncoso
Copy link
Copy Markdown
Contributor

Added some suggestions to improve readability of the UML diagrams regarding the webhook events. Apart from that and the issue at call_origination_and_disconnection.md it looks good and we can merge it as soon as the last issue is created.

Thanks!

@teikuran teikuran requested a review from stroncoso March 24, 2026 04:57
Copy link
Copy Markdown
Contributor

@stroncoso stroncoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @teikuran
Amazing documentation. It looks good to me, also I resolved the outdated conversations as they are already covered.
I'm going to approve the PR, we can merge now or wait for the complete content and the resolved fixed documented. It's up to you.

Thanks a lot for your contribution!

@stroncoso stroncoso merged commit c448a48 into camaraproject:main Mar 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants