generated from camaraproject/Template_API_Repository
-
Notifications
You must be signed in to change notification settings - Fork 5
v2.0.0-rc.1 #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v2.0.0-rc.1 #123
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
692b164
Updated version numbers for release candidate PR
Kevsy 92456cb
Update CHANGELOG.md with r2.1 delta from r1.3
Kevsy 9822ed3
Added PR links for user-facing changes, added a 'Changed' section
Kevsy 03ef08b
Minor formatting updates
Kevsy 17b208d
Added API version to Feature name
Kevsy 62c140a
Version updated to v2.0.0-rc.1
Kevsy 2b94f3f
Reformatted list of issues fixed into PR titles with absolute links
Kevsy c5529af
corrected wrong links
Kevsy 5754be3
fix: commonalities & ICM releases, not versions
Kevsy 0e6bde4
fix: made Commonalities & ICM references links
Kevsy 04c9e60
fix: corrected `vwip` to `v2rc1` in resource URI
Kevsy dfa9d40
fix: corrected template text for Additional Error Responses
Kevsy 0de148c
fix: remove the resource name from the scope
Kevsy e6becf7
fix typo: succesfully->successfully
Kevsy f4b8064
Delete code/API_definitions/README.MD
Kevsy e46c0f1
Updated Release Information
Kevsy 4cb5aa2
fix: removed accidental link
Kevsy 42c904b
fixed URL to release tag
Kevsy 5a330de
fixed public release -> pre-release
Kevsy 380e09c
fix: tag 2.2->2.1
Kevsy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
documentation/API_documentation/simple-edge-discovery_API_Readiness_Checklist.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for curiosity: why this (breaking) change? (I guess both options are correct)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdamker changed because the Design Guide says:
"
api-name is the API name specified as the base path, prior to the API version, in the servers[*].url property. For example, from /location-verification/v1, it would be location-verification.
resource is optional. For APIs with several paths, it may include the resource in the path. For example, from /qod/v1/sessions/{sessionId}, it would be sessions."
"
Since SED has only one path, the optional resource does not apply according to the wording above. As this release is breaking anyway (because of the move from GET to POST) it seems a good time to make the scope name compliant at the same time :)