Skip to content

Fix incorrect ATP time-range assertions#46

Open
albertoramosmonagas wants to merge 1 commit intomainfrom
issue/45
Open

Fix incorrect ATP time-range assertions#46
albertoramosmonagas wants to merge 1 commit intomainfrom
issue/45

Conversation

@albertoramosmonagas
Copy link
Copy Markdown
Contributor

What type of PR is this?

Add one of the following kinds:

  • correction
  • tests

What this PR does / why we need it:

This PR fixes incorrect ATP validation steps for time interval coverage in Predictive Connectivity Data.

The current ATP steps wrongly assume that each returned interval must be strictly contained within the requested time range. However, according to the specification, the returned intervals must fully cover the requested time range, which means:

  • the first interval may start before the requested start time, and
  • the last interval may end after the requested end time.

This PR updates the affected ATP checks so that they validate coverage semantics instead of boundary containment, aligning the tests with the API specification and avoiding false negatives in compliant implementations.

Which issue(s) this PR fixes:

Fixes #45

Special notes for reviewers:

This PR does not change API behavior. It only corrects ATP validation logic so that it matches the interval coverage semantics defined in the specification.

Changelog input

 release-note
Fix ATP time-range validation in Predictive Connectivity Data to check interval coverage semantics instead of strict interval containment.

Additional documentation

This section can be blank.

docs

@github-actions
Copy link
Copy Markdown

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.01s
✅ API spectral 1 0 1.73s
✅ GHERKIN gherkin-lint 1 0 0.39s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.73s
✅ YAML yamllint 1 0 0.49s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix incorrect ATP time-range assertions

1 participant