Fix incorrect ATP time-range assertions#119
Open
albertoramosmonagas wants to merge 2 commits intocamaraproject:mainfrom
Open
Fix incorrect ATP time-range assertions#119albertoramosmonagas wants to merge 2 commits intocamaraproject:mainfrom
albertoramosmonagas wants to merge 2 commits intocamaraproject:mainfrom
Conversation
albertoramosmonagas
requested review from
jgarciahospital,
maheshc01 and
sachinvodafone
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This PR fixes incorrect ATP validation steps for time interval coverage in Population Density Data.
The current ATP steps wrongly assume that each returned interval must be strictly contained within the requested time range. However, according to the specification, the returned intervals must fully cover the requested time range, which means:
This PR updates the affected ATP checks so that they validate coverage semantics instead of boundary containment, aligning the tests with the API specification and avoiding false negatives in compliant implementations.
Which issue(s) this PR fixes:
Fixes #118
Special notes for reviewers:
This PR does not change API behavior. It only corrects ATP validation logic so that it matches the interval coverage semantics defined in the specification.
Please also verify whether the same assertion pattern is present in other ATP scenarios within this repository.
Changelog input
Additional documentation
This section can be blank.