Skip to content

Release r3.2 (Fall25 M4)#119

Merged
bigludo7 merged 17 commits intomainfrom
fix114
Sep 16, 2025
Merged

Release r3.2 (Fall25 M4)#119
bigludo7 merged 17 commits intomainfrom
fix114

Conversation

@bigludo7
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Publication of Fall'25 M4 public release of OTPValidation v1.1.1

Which issue(s) this PR fixes:

Fixes #114

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@bigludo7 bigludo7 requested review from a team and fernandopradocabrillo as code owners August 22, 2025 08:39
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 22, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.01s
✅ API spectral 1 0 1.59s
✅ GHERKIN gherkin-lint 2 0 0.69s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.74s
✅ YAML yamllint 1 0 0.42s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@bigludo7 bigludo7 changed the title Release r3.2 (Fall'25 M4) Release r3.2 (Fall25 M4) Aug 22, 2025
Copy link
Copy Markdown
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @bigludo7! I've corrected a minor typo, the rest is fine from my side

Copy link
Copy Markdown
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release PR is looking good, only point you might want to consider is to mention that this only a patch release of the previous version.

Regarding the content in main some minor issues - which you might want to consider for a next release:


AuthenticationId example and length suggests UUID but no format constraint, no indication of uniqueness guarantees:

    AuthenticationId:
      type: string
      description: unique id of the verification attempt the code belongs to.
      maxLength: 36
      example: ea0840f3-3663-4149-bd10-c7c6b8912105

Typos in .feature files:
sendCode, line 107: max_lenght instead max_length
validateCode, line 166: calidate-code instead of validate-code


The use of 403 for business logic errors looks not compliant with HTTP and CAMARA (should be 422/409)

ONE_TIME_PASSWORD_SMS.MAX_OTP_CODES_EXCEEDED
ONE_TIME_PASSWORD_SMS.PHONE_NUMBER_NOT_ALLOWED # Validation issue - should be 422
ONE_TIME_PASSWORD_SMS.PHONE_NUMBER_BLOCKED # Business rule - could be 422

@hdamker hdamker requested a review from a team September 4, 2025 18:20
@bigludo7
Copy link
Copy Markdown
Collaborator Author

bigludo7 commented Sep 5, 2025

Thanks @hdamker
I've added a sentence as suggested in the changelog.
For the 3 minor issues I've created 3 issues labelled for Spring 26.

@bigludo7 bigludo7 requested a review from hdamker September 15, 2025 08:09
@bigludo7
Copy link
Copy Markdown
Collaborator Author

Hello @hdamker - did you see any blocking point(s) for this one?
Thanks

Copy link
Copy Markdown
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bigludo7

Approved on behalf of Release Management 👏
Next steps for the team:
• [ ] PR merged (by API repository codeowner)
• [ ] Release created within GitHub (by API repository codeowner)
• [ ] Release Tracker updated (with creation date of the release and the release tag link)

@bigludo7 bigludo7 merged commit 4633c6e into main Sep 16, 2025
2 checks passed
@bigludo7 bigludo7 deleted the fix114 branch September 16, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release PR for Fall25 M4 milestone

3 participants