Response schema not aligned with Commonalities guidelines#78
Merged
Masa8106 merged 1 commit intocamaraproject:mainfrom Nov 12, 2025
Merged
Conversation
yamamoto0104
requested review from
Masa8106,
eric-murray and
grgpapadopoulos
as code owners
fernandopradocabrillo
approved these changes
Oct 30, 2025
Contributor
fernandopradocabrillo
left a comment
fernandopradocabrillo
left a comment
There was a problem hiding this comment.
LGTM
thanks @yamamoto0104
grgpapadopoulos
approved these changes
Nov 12, 2025
Masa8106
approved these changes
Nov 12, 2025
Contributor
Masa8106
left a comment
Masa8106
left a comment
There was a problem hiding this comment.
LGTM too. Please let me merge this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The 200 response schema is not aligned with Commonalities Guidelines.
We are using a response object when we should state the schema explicitely.
Which issue(s) this PR fixes:
Fixes #77
Special notes for reviewers:
This PR is for next release.
Changelog input
Additional documentation
None