Update scenarios for non-existent and unable to locate devices#390
Open
Update scenarios for non-existent and unable to locate devices#390
Conversation
Update scenarios for non-existent and unable to locate devices
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
jlurien
reviewed
Mar 23, 2026
Collaborator
There was a problem hiding this comment.
There is no LOCATION_RETRIEVAL.DEVICE_NOT_FOUND defined, we already have @location_retrieval_C01.03_device_not_found defined for this case
Collaborator
Author
There was a problem hiding this comment.
Thanks !
Probably I should remove this @location_retrieval_404_non_existent_device?
Removed scenario for handling non-existent device in location retrieval feature.
Collaborator
Author
|
@jlurien update done. We haven't anymore 404 test scenario but same in location-verification so I guess this is fine and consistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Update scenarios for non-existent and unable to locate devices
Which issue(s) this PR fixes:
Fixes #388
Special notes for reviewers:
To be check if we are ok with 404 test case. I'm wondering if we're not going to far by testing non-existent device.
Changelog input
Additional documentation
This section can be blank.
FYI: @JayVaishnavNio