Skip to content

Update scenarios for non-existent and unable to locate devices#390

Open
bigludo7 wants to merge 2 commits intomainfrom
bigludo7-patch-1
Open

Update scenarios for non-existent and unable to locate devices#390
bigludo7 wants to merge 2 commits intomainfrom
bigludo7-patch-1

Conversation

@bigludo7
Copy link
Copy Markdown
Collaborator

@bigludo7 bigludo7 commented Mar 10, 2026

What type of PR is this?

Add one of the following kinds:

  • bug

What this PR does / why we need it:

Update scenarios for non-existent and unable to locate devices

Which issue(s) this PR fixes:

Fixes #388

Special notes for reviewers:

To be check if we are ok with 404 test case. I'm wondering if we're not going to far by testing non-existent device.

Changelog input

 release-note
- Add a test case for 422 LOCATION_RETRIEVAL.UNABLE_TO_LOCATE
- Update 404 test case to be used for non-existent devices

Additional documentation

This section can be blank.

FYI: @JayVaishnavNio

docs

Update scenarios for non-existent and unable to locate devices
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.01s
✅ API spectral 3 0 4.81s
✅ GHERKIN gherkin-lint 3 0 1.13s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.84s
✅ YAML yamllint 3 0 1.12s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no LOCATION_RETRIEVAL.DEVICE_NOT_FOUND defined, we already have @location_retrieval_C01.03_device_not_found defined for this case

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !
Probably I should remove this @location_retrieval_404_non_existent_device?

Removed scenario for handling non-existent device in location retrieval feature.
@bigludo7
Copy link
Copy Markdown
Collaborator Author

@jlurien update done. We haven't anymore 404 test scenario but same in location-verification so I guess this is fine and consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarification on expected error code when maxAge is absent and device location cannot be determined

2 participants