Conversation
PedroDiez
requested review from
a team,
ToshiWakayama-KDDI and
bigludo7
as code owners
bigludo7
left a comment
bigludo7
left a comment
There was a problem hiding this comment.
LGTM
Thanks @PedroDiez
Thanks for initial review @bigludo7 |
jlurien
left a comment
jlurien
left a comment
There was a problem hiding this comment.
There is some misalignment with the API names:
In the info.title it says "Carrier Billing Refunds", but it the Confluence and in al other places it is singular: "Carrier Billing Refund", we may need to adjust the title then.
For Carrier Billing, in Confluence and trackers it is called "Carrier Billing Checkout", but the term Checkout does not appear in the spec. Should we rename it in Confluence officially to just "Carrier Billing"
documentation/API_documentation/carrier-billing-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/carrier-billing-refund-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
Think makes sense, cc @bigludo7, @rartych I am aligning that way: |
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
…Checklist.md Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
…diness-Checklist.md Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
Yes make sense. |
jlurien
left a comment
jlurien
left a comment
There was a problem hiding this comment.
A couple of comments, for your consideration
README.md
Outdated
| <br>This is a release candidate. Until the public release there are bug fixes to be expected. The release candidate is suitable for implementors, but it is not recommended to use the API with customers in productive environments. | ||
|
|
||
| * The pre-release **r3.1 - rc** is available in [r3.1](https://github.com/camaraproject/CarrierBillingCheckOut/tree/r3.1), and includes the following APIs: | ||
| - API name: Carrier Billing (Payment) - API Definition v0.5.0-rc.1 with inline documentation: |
There was a problem hiding this comment.
If the "(Payment)" is not part of the official API name I would remove it from here
There was a problem hiding this comment.
Yes makes fully sense, thanks for the catch Jose
I make update
|
Note: I have approved as codeowner and not on behalf release management reviewers. |
jlurien
left a comment
jlurien
left a comment
There was a problem hiding this comment.
Approved on behalf of @camaraproject/release-management_reviewers
Next actions to fulfill M3:
- PR merged (by API repository codeowner)
- Release created within GitHub (by API repository codeowner)
- Release Tracker updated (with creation date of the release and the release tag link)
3 participants
What type of PR is this?
What this PR does / why we need it:
Release 3.1 (Release candidate) PR for Carrier Billing APIs within Fall25 MetaRelease (M3)
Which issue(s) this PR fixes:
Carrier Billing:
Fixes #214
Fixes #216
Fixes #223
Fixes #224
Fixes #225
Carrier Billing Refund:
Fixes #216
Fixes #219
Fixes #220
Fixes #221
Special notes for reviewers:
Carrier Billing:
Fixes #214. Already covered in PR #217
Fixes #216. Already covered in PR #226
Fixes #223. Already covered in PR #229
Fixes #224. Covered in this PR
Fixes #225. Already covered in PR #230
Carrier Billing Refund:
Fixes #216. Already covered in PR #226
Fixes #219. Already covered in PR #229
Fixes #220. Covered in this PR
Fixes #221. Already covered in PR #230
Changelog input
Additional documentation
N/A