-
Notifications
You must be signed in to change notification settings - Fork 50
Many QOL features and bug fixes #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ah, I see. I think someone (probably ADoS) said we shouldn't put it on the first page until it has undergone some revisions to meet a minimum quality standard, but certainly it's bad if it can be accessed at all before then.
What overengineering? You already wrote code to do that work for the purpose of producing the meta file. Just leave the code (or a minor variation on it) active in the released build? |
|
I've moved off of this branch -- closing for now. |
My free time is gonna be a lot more limited in the near future so I wanted to make a big push and implement every quality of life feature left on my checklist, even if it meant moving too fast and getting messy.
I have now done that. (As well as fix a lot of legacy scenario compatibility stuff, sometimes in ways that presuppose the existence of my scenario archive submodule in the build and
meta.xmlfiles which currently only contain encodings. It also assumes that legacy scenarios in the custom scenario folder are in individual folders, not dumped into a flat folder structure with lots of floating READMEs.)So not all of this should be merged upstream, but most of it should be, once sorted out, vetted and made more sane. I figured I would make one big PR so you can see everything I've done, but I will split it into smaller PRs and/or cherry-picks like we did with the big Fosnola PRs.
Implements #779
Implements #727 - my minimap overhaul lets you see sign text, area descriptions, vehicle locations, and town entrances by mousing over them. I think this is a huge QOL improvement, but may spoil certain things if the player reads a sign's tooltip but the sign is inaccesible (ie on the other side of a wall). I think I'm comfortable with that tradeoff. It could also be made a preference, "Annotated minimap" or something. I don't think it should be a feature flag, because it improves the experience in legacy scenarios just as much as new ones.
I think this contains everything in PR #773, and probably more related fixes that should be added to that PR.