Skip to content

Conversation

@egoist
Copy link

@egoist egoist commented Dec 16, 2016

No description provided.

@espehel
Copy link

espehel commented Jan 30, 2018

Any chance of seeing this PR merged? @callmecavs

@callmecavs
Copy link
Owner

callmecavs commented Jan 30, 2018

@espehel probably not as is - the PR includes a bunch of other changes that go against the code style, etc.

it's easy enough to implement this outside the library, as follows:

const target = document.querySelector('selector')

if (!target) {
  // handle invalid target here
  return
} else {
  jump(target, { duration: 1000 })
}

the check might also need to be a bit more complete - like test for instanceof HTMLElement or something along those lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants