Open
Conversation
Signed-off-by: cui fliter <imcusg@gmail.com>
Signed-off-by: Afshin Paydar <afshin.paydar@binary.com>
Signed-off-by: trevor tao <trevor.tao@arm.com>
Based on the comments from the community, do the following changes to the code of fv test support on arm64: 1. Set the common code as a function to utils.go 2. Revise the code accordingly It should also support other archs with more tests. Signed-off-by: trevor tao <trevor.tao@arm.com>
For the Linux network device naming rules talked in [0],[1]:
prefix [Pdomain] pbus sdevice [ffunction] [nphys_port_name | ddev_port]
The domain is omitted if it's 0 and the function is only present if
it's a multi-function device. But for some network devices and/or Linux
system, the domain is non-zero, so the pattern would be "enPxxxxxx".
On the other side, from the real case showed in our server,
the ethernet interface name like "enP1p1s0f1" is valid as
a normal data interface.
Now we lack this pattern in BPFDataIfacePattern, so for the bpf's ifstate map,
this interface would be skipped as:
felix/bpf_ep_mgr.go 516: Ignoring interface that's neither data nor workload.
update=&intdataplane.ifaceUpdate{Name:"enP1p1s0f1", State:"up", Index:4}
This lack would affect the normal work of eBPF communication since it would lack
in the eBPF ifstate map which would be used in cali_iface_lookup_elem(&ifindex).
This PR is also part of the fix for the issue of:
projectcalico#6392
[0] https://utcc.utoronto.ca/~cks/space/blog/linux/UdevNetworkDeviceNaming
[1] https://www.freedesktop.org/software/systemd/man/systemd.net-naming-scheme.html
Signed-off-by: trevor tao <trevor.tao@arm.com>
For the Linux network device naming rules talked in [0],[1]: prefix [Pdomain] pbus sdevice [ffunction] [nphys_port_name | ddev_port] The domain is omitted if it's 0 and the function is only present if it's a multi-function device. But for some network devices and/or Linux system, the domain is non-zero, so the pattern would be "enPxxxxxx". On the other side, from the real case showed in our server, the ethernet interface name like "enP1p1s0f1" is valid as a normal data interface. Now we lack this pattern in MTUIfacePattern, so when findHostMTU, this kind of interfaces would be skipped. It will affect the final MTU calculation for this miss. [0] https://utcc.utoronto.ca/~cks/space/blog/linux/UdevNetworkDeviceNaming [1] https://www.freedesktop.org/software/systemd/man/systemd.net-naming-scheme.html Signed-off-by: trevor tao <trevor.tao@arm.com>
… DOCS-436/master
Signed-off-by: xin.li <xin.li@daocloud.io>
Signed-off-by: xin.li <xin.li@daocloud.io>
hedibouattour
force-pushed
the
feature/wip-fv-tests-vpp
branch
from
b4fe579 to
63a1901
Compare
run make generate
…nforceRPF_Loose_Option_Rebase Add Loose option to BPFEnforceRPF option
The change to use spider to reduce the number of packages to run the tests in removed filtering out packages that have no test files. This breaks some things downstream as there's packages without tests with different build constraints.
…ories-to-run-tests-on Filter list of directories to run tests on to only those that have tests
It is pretty much a global setting, mostly turned on.
…-with-new-config fix vpp doc with new calicovpp configuration
There was a bug in this scenario: - Ingress and egress rules both become active, using the same service. - Either rule becomes inactive. - Service index would clean up the endpoints to IP set mapping for both IP sets. - Updates to endpoint slices were then ignored for the remaining IP set.
Fix incorrect map cleanup in service policy index.
cleanup: remove old apiversion for deployment
hedibouattour
force-pushed
the
feature/wip-fv-tests-vpp
branch
26 times, most recently
from
41532f4 to
e14b4f1
Compare
hedibouattour
force-pushed
the
feature/wip-fv-tests-vpp
branch
2 times, most recently
from
de3ebb4 to
a92739f
Compare
hedibouattour
force-pushed
the
feature/wip-fv-tests-vpp
branch
from
a92739f to
f42ca72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.